fix(ui): recover from a dead session instead of stranding the operator - #93
Merged
Conversation
A token the server no longer accepts (expired, revoked, or issued for a project the show is no longer running) left the artist UI retrying forever behind a red dot with no way out — the diagnosis said "sign in again" but there was nothing to sign in with. The dead token is now dropped and the login screen comes back, saying why it appeared and prefilling the username that was last signed in here.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#92 made the red dot say "Your session expired or was revoked — sign in again", but there was nothing to sign in with: the header still showed the username,
useSocketkept reconnecting with the same dead token, and every retry re-diagnosed the same 401. A dead-end.Sessions are stored per project, so this is easy to hit now that switching the project in use restarts the brain — the token was minted against the previous project's session list.
A
sessionExpireddiagnosis (which only fires when/api/configis healthy and/api/me401s, so the server is definitively rejecting this token) now clears it:useAuthgrowssessionEnded()(a logout that records why) and remembers the last username inwg_last_user, so the login screen returns with a reason and one field left to fill:rejecteddeliberately does not sign out:/api/mepassed there, so the token is fine and signing out would lose a good session over a server-side problem.Link to Devin session: https://app.devin.ai/sessions/972698f89f494b86828010666a002b8f
Requested by: @pyramation